Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Refactor common bits from envoy/listeners #3116

Closed
wants to merge 1 commit into from

Conversation

stevesloka
Copy link
Member

Updates #1898

Signed-off-by: Steve Sloka slokas@vmware.com

Updates projectcontour#1898

Signed-off-by: Steve Sloka <slokas@vmware.com>
@stevesloka stevesloka added this to the 1.11.0 milestone Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #3116 (8528d61) into main (2885e38) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3116   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files         102      103    +1     
  Lines        6184     6184           
=======================================
  Hits         4533     4533           
  Misses       1551     1551           
  Partials      100      100           
Impacted Files Coverage Δ
internal/envoy/v2/listener.go 96.74% <ø> (-0.28%) ⬇️
cmd/contour/servecontext.go 56.81% <100.00%> (ø)
internal/envoy/listener.go 100.00% <100.00%> (ø)
internal/xdscache/v2/listener.go 95.10% <100.00%> (ø)

@stevesloka stevesloka closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant