internal/envoy: Enable xDS v3 Clusters

[stevesloka]

Enables v3 xDS Clusters as well as supporting structs.

Updates #1898

Signed-off-by: Steve Sloka slokas@vmware.com

[codecov]

Codecov Report

Merging #3114 (6c8e20f) into main (2885e38) will increase coverage by 0.07%.
The diff coverage is 77.04%.

@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
+ Coverage   73.30%   73.37%   +0.07%     
==========================================
  Files         102      104       +2     
  Lines        6184     6367     +183     
==========================================
+ Hits         4533     4672     +139     
- Misses       1551     1593      +42     
- Partials      100      102       +2     

Impacted Files	Coverage Δ
internal/envoy/v3/auth.go	61.70% <61.70%> (ø)
internal/envoy/v3/cluster.go	80.80% <77.98%> (-19.21%)	⬇️
internal/envoy/v3/healthcheck.go	100.00% <100.00%> (ø)
internal/dag/cache.go	95.36% <0.00%> (-0.78%)	⬇️

[skriss]

Is it possible going forward to make a first commit that copies files from v2->v3 as-is, and then a second commit that does all the fixup to make it work for v3? I think it'll make it much easier to review since we can just look at diffs on the second commit.

[skriss]

I assume you're holding off on wiring this up to the v3 xDS servers for another PR?

[stevesloka]

Is it possible going forward to make a first commit that copies files from v2->v3 as-is, and then a second commit that does all the fixup to make it work for v3? I think it'll make it much easier to review since we can just look at diffs on the second commit.

Yup I can do that now. The one bit is there are a few things partially moved due to needing them in v3 bootstrap.

[stevesloka]

The one bit is there are a few things partially moved due to needing them in v3 bootstrap.

My thought was to:

1. Get the conflicting bits merged into v3
2. copy/paste other files from v2 --> v3
3. Bump up the v3 copied files into v3 version
4. Upgrade feature tests

Probably need to to do this at some smallish rate to make it easier?