internal/featuretests: Refactor featuretests into v2 package #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2930 +/- ##
==========================================
- Coverage 74.51% 74.47% -0.04%
==========================================
Files 92 92
Lines 5960 5960
==========================================
- Hits 4441 4439 -2
- Misses 1422 1423 +1
- Partials 97 98 +1
|
|
rebase time! |
stevesloka
force-pushed
the
refactorFeaturetestsv2
branch
from
54f474b
to
f3ce1db
Compare
…ckage for Envoy API V2 types Refactors the featuretests package into a v2 package. Common items are kept in the feature package for use by other versions. Updates: projectcontour#1898 Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
refactorFeaturetestsv2
branch
from
f3ce1db
to
2d78797
Compare
|
I tried to make this as simple as possible so not much code changes. There are some bits that we can reuse in the |
skriss
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the featuretests package into a v2 package for Envoy API V2 types.
Common items are kept in the feature package for use by other versions.
Updates: #1898
Blocked on #2928