internal: test reliability improvements #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch from shutting down gRPC server with `Stop()` to `GracefulStop()`. which waits for current requests to drain before returning. This means that tests which log to the test runner won't ever attempt to log after the test has completed. * Hoist test loggers into the fixtures package and use them from there. * Add a workgroup context cancellation test. This updates projectcontour#2775. Signed-off-by: James Peach <jpeach@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #2780 +/- ##
==========================================
- Coverage 76.67% 76.58% -0.09%
==========================================
Files 72 73 +1
Lines 5792 5788 -4
==========================================
- Hits 4441 4433 -8
- Misses 1259 1264 +5
+ Partials 92 91 -1
|
jpeach
added a commit
to jpeach/contour
that referenced
this pull request
Aug 17, 2020
Fix a regression from projectcontour#2780, where the Contour xDS server would fail to stop because it is waiting for xDS connections to drain (they won't drain). This updates projectcontour#2780. Signed-off-by: James Peach <jpeach@vmware.com>
jpeach
added a commit
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from shutting down gRPC server with
Stop()toGracefulStop().which waits for current requests to drain before returning. This
means that tests which log to the test runner won't ever attempt to
log after the test has completed.
Hoist test loggers into the fixtures package and use them from there.
Add a workgroup context cancellation test.
This updates #2775.
Signed-off-by: James Peach jpeach@vmware.com