Instrument gRPC server with go-grpc-prometheus middleware (#1678) #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tour#1678) Signed-off-by: Benoit Gagnon <benoit.gagnon@ubisoft.com>
davecheney
suggested changes
Oct 14, 2019
pass in the Prometheus Registry to the constructor so that grpcServer can remain an internal struct Signed-off-by: Benoit Gagnon <benoit.gagnon@ubisoft.com>
|
Hey @bgagnon I was able to test this in my cluster and I see the metrics from Prometheus, but like your example pasted above, there are no values for anything. Is this typical for these types of metrics? |
|
I'm also checking this out in my cluster, and I can see some stats, I'm going to spend a while and check that the stats mean what I think they do before giving this the thumbs up. But overall, it looks pretty good, thanks @bgagnon for doing this work! |
davecheney
approved these changes
Oct 16, 2019
|
Okay, I'm happy we'll get some metrics, we can look more at what else we can get as a next step. |
This was referenced Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic integration of the go-grpc-prometheus middleware -- see #1678.
Out of the box, we get the following new timeseries: