Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RateLimiting implementation #1463

Closed
wants to merge 1 commit into from
Closed

Conversation

zxvdr
Copy link
Contributor

@zxvdr zxvdr commented Sep 5, 2019

Fixes #370

Signed-off-by: Steve Sloka slokas@vmware.com

Signed-off-by: Steve Sloka <slokas@vmware.com>
@davecheney
Copy link
Contributor

@zxvdr Thank you for your contribution, however this appears to be #873 pushed as your own branch. I'm going to close this as its probably an error. If you would like to discuss rate limiting please do so on #873 or #843

@davecheney davecheney closed this Sep 9, 2019
@zxvdr
Copy link
Contributor Author

zxvdr commented Sep 10, 2019

@davecheney, it wasn't an error. I asked @stevesloka the status of #873 and offered to help get it over the line. He suggested opening a new PR. This is #873 rebased with most of the previous review comments addressed. Apologies for omitting these details earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add rate limiting support
3 participants