Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"build and push a release" workflow is broken #4309

Closed
skriss opened this issue Jan 28, 2022 · 0 comments · Fixed by #4310
Closed

"build and push a release" workflow is broken #4309

skriss opened this issue Jan 28, 2022 · 0 comments · Fixed by #4310
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@skriss
Copy link
Member

skriss commented Jan 28, 2022

https://github.com/projectcontour/contour/runs/4983758966?check_suite_focus=true

Our v1.20.0 build failed. We've switched from actions/checkout@v1 to actions/checkout@v2 recently, and it seems like the checkout behavior has changed such that it now checks out the tag itself, which then leads to an error when our release script tries to fetch all tags.

@skriss skriss added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jan 28, 2022
skriss added a commit to skriss/contour that referenced this issue Jan 28, 2022
Adds `--force` to `git fetch --tags` to
work with the v2 checkout action.

Closes projectcontour#4309.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Jan 28, 2022
Adds `--force` to `git fetch --tags` to
work with the v2 checkout action.

Closes projectcontour#4309.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Jan 31, 2022
Adds `--force` to `git fetch --tags` to
work with the v2 checkout action.

Closes #4309.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Jan 31, 2022
Adds `--force` to `git fetch --tags` to
work with the v2 checkout action.

Closes #4309.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant