Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

DO NOT MERGE: Updates Services for Port Names #150

Closed
wants to merge 1 commit into from

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Dec 3, 2020

Updates the Contour and Envoy service to use named target ports. Names provide greater flexibility for supporting different container networking use cases According to k8s docs:

Port definitions in Pods have names, and you can reference these names in the targetPort attribute of a Service. This works even if there is a mixture of Pods in the Service using a single configured name, with the same network protocol available via different port numbers. This offers a lot of flexibility for deploying and evolving your Services. For example, you can change the port numbers that Pods expose in the next version of your backend software, without breaking clients.

Signed-off-by: Daneyon Hansen daneyonhansen@gmail.com

Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
@Miciah
Copy link

Miciah commented Dec 3, 2020

/lgtm

Copy link
Member

@stevesloka stevesloka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never been a fan of port names, to me the actual port numbers are more straight forward to understand what is actually in use. Just my 2 cents.

@danehans
Copy link
Contributor Author

I've never been a fan of port names, to me the actual port numbers are more straight forward to understand what is actually in use. Just my 2 cents.

@stevesloka My thinking is that using port name references will make easier to implement #151. I'll put a hold on this PR and reopen if this ends up being the case.

@danehans danehans changed the title Updates Services for Port Names DO NOT MERGE: Updates Services for Port Names Dec 10, 2020
@danehans
Copy link
Contributor Author

#152 does not use port names, so I'm closing this PR.

@danehans danehans closed this Dec 14, 2020
@danehans danehans deleted the envoy_ports branch February 23, 2021 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants