calico/go-build s390x image on Dockerhub seems to be missing tools for testing#442
Closed
rposts wants to merge 2 commits intoprojectcalico:masterfrom
Closed
calico/go-build s390x image on Dockerhub seems to be missing tools for testing#442rposts wants to merge 2 commits intoprojectcalico:masterfrom
rposts wants to merge 2 commits intoprojectcalico:masterfrom
Conversation
3 tasks
Author
|
Please let me know how we can proceed with this PR - Thanks! |
Collaborator
|
This PR should be addressed in #490. Let me know if anything is missing from current master. |
Collaborator
|
Close as completed in #490. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running Calico testcases on
s390xarch it is observed thatcalico/go-build:v0.85-s390xdoes not contain few components when compared toamd64. This is also evident in the image files sizes fors390x(498.06MB) andamd64(1.08 GB).This PR attempts to bring
s390ximage closer toamd64.Since
Dockerfile.s390xchanges implemented by this PR require correctcalico/bpftool:v5.3-s390ximage, this issue must be also be addressed first: projectcalico/calico#7654Thanks.