Re-enable golangci-lint #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelvanoni
requested review from
spikecurtis and
caseydavenport
and removed request for
spikecurtis
| @@ -478,6 +495,6 @@ func main() { | |||
| initConfiguration() | |||
|
|
|||
| if err = rootCmd.Execute(); err != nil { | |||
| genericUnsupported("not supported", "", err.Error()) | |||
| _ = genericUnsupported("not supported", "", err.Error()) | |||
There was a problem hiding this comment.
Should we handle this error explicitly? I think probably should at least log it.
There was a problem hiding this comment.
I'm a bit hesitant to log this since whoever's calling a command that isn't supported might be doing it periodically, and logging it would lead to large log files (similar to https://github.com/projectcalico/pod2daemon/issues/20). Wdyt?
There was a problem hiding this comment.
...but this is in main() and not one of the other similar calls, so ok :-)
There was a problem hiding this comment.
...and genericUnsupported() already logs it
caseydavenport
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.