Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce felix FV log severity; add env var to override for debug #2862

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Reduce felix FV log severity; add env var to override for debug #2862

merged 2 commits into from
Jun 22, 2021

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Jun 22, 2021

Description

Debug logging generates a lot of output when a test fails and that can cause problems:

  • Ginkgo uses a lot of RAM to buffer the logs.
  • The log become unwieldy for Semaphore.

Change the default to be info everywhere but add an env var to override it

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

None required

@fasaxc fasaxc requested a review from a team as a code owner June 22, 2021 13:41
@marvin-tigera marvin-tigera added this to the Calico v3.20.0 milestone Jun 22, 2021
nelljerram
nelljerram approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@nelljerram nelljerram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One naming query.

Makefile Outdated
@@ -354,6 +354,7 @@ fv fv/latency.log fv/data-races.log: $(REMOTE_DEPS) image-test bin/iptables-lock
FV_K8SIMAGE=$(FV_K8SIMAGE) \
FV_NUM_BATCHES=$(FV_NUM_BATCHES) \
FV_BATCHES_TO_RUN="$(FV_BATCHES_TO_RUN)" \
FELIX_FV_FELIX_LOG_LEVEL="$(FELIX_FV_FELIX_LOG_LEVEL)" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need two FELIX here, and FV_FELIX_LOG_LEVEL would look more like other settings.

@Brian-McM Brian-McM merged commit 91f2dbe into projectcalico:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelljerram nelljerram nelljerram approved these changes

Assignees
No one assigned
Labels
docs-not-required release-note-not-required
Projects
None yet
Milestone
Calico v3.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fasaxc @nelljerram @caseydavenport @Brian-McM @marvin-tigera