Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine bpf fvs #2856

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Combine bpf fvs #2856

merged 2 commits into from
Jun 21, 2021

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Jun 21, 2021

Description

Run all the "new kernel" tests in parallel from a single semaphore runner instead of one per batch.

The tests actually run in GCP on instances with newer kernels so we were wasting a lot of Semaphore capacity just waiting for those GCP VMs to finish running tests.

  • Introduce new scripts to create all the GCP VMs at once and then to run all the tests in parallel.
  • Start a background thread to grep the output of each test for interesting phrases like "Failure".
  • Store off all the FV logs as artifacts.

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

None required

Brian-McM
Brian-McM previously approved these changes Jun 21, 2021
Copy link
Contributor

@Brian-McM Brian-McM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just wonderful, thank you!

@bcreane
Copy link
Contributor

bcreane commented Jun 21, 2021

awesome!

@Brian-McM Brian-McM dismissed their stale review June 21, 2021 20:03

Artifact collection failed

Copy link
Contributor

@Brian-McM Brian-McM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re approving, I just didn't look in the right place for the artifacts.

@Brian-McM Brian-McM merged commit 169d9f3 into projectcalico:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants