Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce organisation impact of semaphore job #2854

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Reduce organisation impact of semaphore job #2854

merged 4 commits into from
Jun 21, 2021

Conversation

fasaxc
Copy link
Member

@fasaxc fasaxc commented Jun 21, 2021 •
edited
Loading

Description

Proposing a few changes to the semaphore job to increase efficiency at the expense of a slightly longer job times (and some other changes):

  • Coalesce the build, UT, k8sfv, image-all jobs into one job that is run first. Previously, the jobs took an aggregate of ~32minutes but combining them reduces that to 14 minutes due to being able to make use of the warm go build cache etc.
  • Enable auto-cancel for master; I think it's pretty rare that we queue up multiple master builds but it might help when we're doing a lot of pin updates etc.

Todos

  • Unit tests (full coverage)
  • Integration tests (delete as appropriate) In plan/Not needed/Done
  • Documentation
  • Backport
  • Release note

Release Note

None required

@marvin-tigera marvin-tigera added this to the Calico v3.20.0 milestone Jun 21, 2021
@fasaxc
Auto-cancel all in-progress jobb, even on master.
2b93f66
@fasaxc
Add queues for PRs and non-PR builds.
8ac89dc 
- Run PR builds in parallel (as now).
- Queue everything else up serially.
- Classify pin update PRs as "everything else".
@fasaxc fasaxc changed the title Reduce width of felix sempahore job. Reduce organisation impact of semphore job Jun 21, 2021
@fasaxc fasaxc changed the title Reduce organisation impact of semphore job Reduce organisation impact of semaphore job Jun 21, 2021
@fasaxc fasaxc marked this pull request as ready for review June 21, 2021 13:23
@fasaxc fasaxc requested a review from a team as a code owner June 21, 2021 13:23
Brian-McM
Brian-McM approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@Brian-McM Brian-McM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for doing that!

@Brian-McM Brian-McM merged commit e698ad1 into projectcalico:master Jun 21, 2021
@fasaxc fasaxc mentioned this pull request Jun 22, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelljerram nelljerram nelljerram left review comments

@Brian-McM Brian-McM Brian-McM approved these changes

Assignees
No one assigned
Labels
docs-not-required release-note-not-required
Projects
None yet
Milestone
Calico v3.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fasaxc @nelljerram @Brian-McM @marvin-tigera