Install only wireguard-tools, rev text VMs to 20.04 #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasaxc
added
docs-not-required
release-note-not-required
cherry-pick-candidate
and removed
docs-pr-required
release-note-required
labels
nelljerram
approved these changes
Jun 10, 2020
Should support wireguard out of the box.
fasaxc
changed the title
| @@ -19,4 +19,4 @@ FROM ubuntu:eoan | |||
| LABEL maintainer="Gaurav <gaurav@tigera.io>" | |||
|
|
|||
| RUN apt-get update && \ | |||
| apt-get install wireguard -y | |||
| apt-get install --no-install-recommends wireguard-tools -y | |||
There was a problem hiding this comment.
Does this need to be "FROM ubuntu:focal"?
realgaurav
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
CI passing, @fasaxc let's get this one in.
We can address any OS and package changes later.
Thanks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid installing the wireguard kernel module in the docker image. It's not needed and it has started pulling in dependencies such as grub, causing the build to fail.
Todos
Release Note