Fix VXLAN race condition #2260
Merged
Fix VXLAN race condition #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseydavenport
commented
Apr 16, 2020
| @@ -60,9 +60,8 @@ func init() { | |||
|
|
|||
| // Constants that are shared with the UT binaries that we build. | |||
| const ( | |||
| natTunnelMTU = uint16(700) | |||
| ethernetHeaderSize = 14 | |||
There was a problem hiding this comment.
Static checks complained about this const being unused.
/shrug
fasaxc
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race in VXLAN resolver where we don't get cross subnet routes.
Already fixed in master due to a refactoring of the route resolution code by @fasaxc .
This is a small patch to earlier releases to fix the same issue.
projectcalico/calico#3231
Todos
Release Note