Send ICMP too bigs directly #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to check mtu if we do dsr, so check dsr first
On the return path into a nodeport tunnel, we can rely on the fact that we encaping the return traffic in the host namespace, large packets are GSO (because of veth) and the host iface will segment the encaped packets correctly based on the host iface MTU. base csum_offset on iphdr offset and ihl, it makes the offset correct with IP options.
Althoug may not be 100% precise, gso_segs > 1 should be a good sign that we are handling GSO packet and thus we do not need to care about the mtu in tcp case.
fasaxc
added
docs-not-required
release-note-not-required
and removed
docs-pr-required
release-note-required
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes #2222 plus markups.
Todos
Release Note