Only log on err

projectcalico · May 22, 2020 · 26da27e · 26da27e
1 parent 3bce00a
commit 26da27e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/dataplane/linux/endpoint_mgr.go b/dataplane/linux/endpoint_mgr.go
@@ -1033,10 +1033,12 @@ func (m *endpointManager) configureInterface(name string) error {
 		return nil
 	}
 
-	// Try setting accept_ra to 0 and only log if it failed (it might fail if IPv6
+	// Try setting accept_ra to 0 and just log if it failed (it might fail if IPv6
 	// was disabled).
 	err := m.writeProcSys(fmt.Sprintf("/proc/sys/net/ipv6/conf/%s/accept_ra", name), "0")
-	log.WithField("ifaceName", name).Warnf("Could not set accept_ra: %v", err)
+	if err != nil {
+		log.WithField("ifaceName", name).Warnf("Could not set accept_ra: %v", err)
+	}
 
 	log.WithField("ifaceName", name).Info(
 		"Applying /proc/sys configuration to interface.")