Fix CI script bugs in wait-for-test-completion and cache-test-artifacts#12330
Open
fasaxc wants to merge 1 commit intoprojectcalico:masterfrom
Open
Fix CI script bugs in wait-for-test-completion and cache-test-artifacts#12330fasaxc wants to merge 1 commit intoprojectcalico:masterfrom
fasaxc wants to merge 1 commit intoprojectcalico:masterfrom
Conversation
- wait-for-test-completion: Validate test.pid exists and contains a
numeric PID before checking /proc. Previously, a missing or empty
test.pid would cause `[ -e "/proc/" ]` to always be true, hanging
the CI job forever.
- felix/.semaphore/cache-test-artifacts: Prefix tar --exclude patterns
with ${CALICO_DIR_NAME}/ so they actually match the archived paths.
Without the prefix, excludes like .go-pkg-cache and artifacts had
no effect, making the working-copy tarball unnecessarily large.
- node/.semaphore/cache-test-artifacts: Same tar --exclude fix.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
marvin-tigera
added
release-note-required
fasaxc
added
docs-not-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes correctness issues in Semaphore CI helper scripts used to run tests on VMs and cache/upload working-copy artifacts to GCS, preventing hangs and ensuring tar exclusions actually apply when the archive root is the checkout directory.
Changes:
- Make
felix/.semaphore/wait-for-test-completionvalidatetest.pidexistence and numeric content to avoid an infinite wait when the PID file is missing/invalid. - Update
felix/.semaphore/cache-test-artifactstar--excludepaths to be rooted at${CALICO_DIR_NAME}/...so excludes match aftercd ../... - Apply the same tar exclude rooting fix to
node/.semaphore/cache-test-artifacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
felix/.semaphore/wait-for-test-completion |
Prevents CI hangs by treating missing/invalid test.pid as an error and returning 66. |
felix/.semaphore/cache-test-artifacts |
Fixes tar exclusion patterns so unwanted dirs don’t get included in the uploaded working copy. |
node/.semaphore/cache-test-artifacts |
Same tar exclusion fix for node FV artifact caching. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three bugs in CI scripts found by Copilot review of #12195:
wait-for-test-completion: If
test.pidis missing or unreadable,cat test.pidreturns empty, so the check[ -e "/proc/" ]is always true, causing an infinite CI hang. Now validates thattest.pidexists and contains a numeric PID, exiting with code 66 (the "something went wrong" code) otherwise.felix/.semaphore/cache-test-artifacts:
tar --excludepatterns like--exclude=.go-pkg-cachedon't match when the archive root is${CALICO_DIR_NAME}/...(aftercd ../..). Prefix excludes with${CALICO_DIR_NAME}/so they actually take effect, reducing the working-copy tarball size.node/.semaphore/cache-test-artifacts: Same tar exclude fix.