Migrate to Ginkgo v2#11797
Merged
coutinhop merged 7 commits intoprojectcalico:masterfrom Feb 13, 2026
Merged
Conversation
16b4b6d to
68970f4
Compare
f742974 to
093a0d1
Compare
Contributor
Author
|
UT/FV test results after this change:
Comparing to a master run:
|
fasaxc
approved these changes
Feb 10, 2026
| github.com/onsi/ginkgo v1.16.5 | ||
| github.com/onsi/ginkgo/v2 v2.27.2 | ||
| github.com/onsi/gomega v1.38.2 | ||
| github.com/onsi/ginkgo/v2 v2.28.1 |
Member
There was a problem hiding this comment.
Worth a pre-flight check to ban accidental re-introduction of v1?
Contributor
Author
There was a problem hiding this comment.
Added a check-ginkgo-v2 preflight check in 07f5bf5.
coutinhop
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This changeset migrates all test suites from Ginkgo v1 to v2. The major changes are in the Felix FV tests, where a static sharding helper
configureManualShardingis implemented to preserve the v1-style "shard-nothing" execution and reporting behavior. It also adds aReportAfterSuitehook to filter out skipped and pending tests, as well as standard output from passed tests, to avoid bloated JUnit reports.Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.