Skip to content

Commit

Permalink
Merge pull request #48 from caseydavenport/fix-release
Browse files Browse the repository at this point in the history
Fix release
  • Loading branch information
caseydavenport authored Sep 24, 2018
2 parents 72812cc + d172cc6 commit 6113bb0
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ ifeq ($(ARCH),x86_64)
override ARCH=amd64
endif


# we want to be able to run the same recipe on multiple targets keyed on the image name
# to do that, we would use the entire image name, e.g. calico/node:abcdefg, as the stem, or '%', in the target
# however, make does **not** allow the usage of invalid filename characters - like / and : - in a stem, and thus errors out
Expand All @@ -54,7 +53,6 @@ comma := ,
prefix_linux = $(addprefix linux/,$(strip $1))
join_platforms = $(subst $(space),$(comma),$(call prefix_linux,$(strip $1)))


# list of arches *not* to build when doing *-all
# until s390x works correctly
EXCLUDEARCH ?= s390x
Expand Down Expand Up @@ -111,7 +109,6 @@ DOCKER_RUN_RM:=docker run --rm \
$(EXTRA_DOCKER_ARGS) \
--user $(LOCAL_USER_ID):$(MY_GID) -v $(CURDIR):/code


ENVOY_API=vendor/github.com/envoyproxy/data-plane-api
EXT_AUTH=$(ENVOY_API)/envoy/service/auth/v2alpha/
ADDRESS=$(ENVOY_API)/envoy/api/v2/core/address
Expand Down Expand Up @@ -404,7 +401,7 @@ endif
## Verifies the release artifacts produces by `make release-build` are correct.
release-verify: release-prereqs
# Check the reported version is correct for each release artifact.
if ! docker run $(BUILD_IMAGE):$(VERSION)-$(ARCH) /dikastes --version | grep 'Version:\s*$(VERSION)$$'; then \
if ! docker run $(BUILD_IMAGE):$(VERSION)-$(ARCH) /dikastes --version | grep '^$(VERSION)$$'; then \
echo "Reported version:" `docker run $(BUILD_IMAGE):$(VERSION)-$(ARCH) /dikastes --version` "\nExpected version: $(VERSION)"; \
false; \
else \
Expand All @@ -423,7 +420,7 @@ release-publish: release-prereqs
git push origin $(VERSION)

# Push images.
$(MAKE) push-all IMAGETAG=$(VERSION)
$(MAKE) push-all push-manifests push-non-manifests IMAGETAG=$(VERSION)

@echo "Finalize the GitHub release based on the pushed tag."
@echo ""
Expand All @@ -438,7 +435,7 @@ release-publish: release-prereqs
# run this target for alpha / beta / release candidate builds, or patches to earlier Calico versions.
## Pushes `latest` release images. WARNING: Only run this for latest stable releases.
release-publish-latest: release-prereqs
$(MAKE) push-all IMAGETAG=latest
$(MAKE) push-all push-manifests push-non-manifests IMAGETAG=latest

# release-prereqs checks that the environment is configured properly to create a release.
release-prereqs:
Expand Down

0 comments on commit 6113bb0

Please sign in to comment.