metrics: properly escape commas in exception text

The most secure way is using json.dumps
projectatomic · Oct 25, 2016 · 24af9a6 · 24af9a6
1 parent b7a1608
commit 24af9a6
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/metrics.py b/metrics.py
@@ -149,7 +149,9 @@ def get_stats(self):
                 errors = plugins_metadata['errors']
                 first_failed = sorted(errors.keys())[0]
                 plugins['failed_plugin'] = first_failed
-                plugins['exception'] = errors[first_failed].split("(")[0].replace(',', ' ')
+                exception_text = errors[first_failed].split("(")[0]
+                # Make sure quotes and commas are escaped
+                plugins['exception'] = json.dumps(exception_text)
             except (KeyError, IndexError):
                 pass