Fix sfdisk failure on older sfdisk #246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to use following input file for sfdisk.
units:sectors
{dev}1: start=2048, size=4096, Id=8e
And this worked both with old and new sfdisk. But this required
hardcoding partition name and we wanted to move away from that
as it did not work for pmem and loop devices. So we started using
following format instead.
units:sectors
start=2048, size=4096, Id=8e
As per latest sfdisk man page this should work but it does not seem to
work with sfdisk shipped with older util-linux (util-linux-2.23.2-33),
and we get errors like following.
sfdisk: trailing junk after number
sfdisk: bad input
But following format seems to work with old sfdisk format. So switch
to using that one.
units:sectors
2048, 4096, 8e
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Collaborator
Author
|
cc @rhatdan |
Member
|
If this works it LGTM |
Collaborator
Author
|
cc @qiancai |
|
All tests passed on rhel atomic host. |
Collaborator
Author
|
@qiancai Thanks. I will merge this PR. |
Collaborator
Author
|
☀️ Test successful - status-redhatci |
Member
|
Random thing on this topic I saw go by today: http://marc.info/?l=linux-fsdevel&m=149881066814568&w=2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to use following input file for sfdisk.
units:sectors
{dev}1: start=2048, size=4096, Id=8e
And this worked both with old and new sfdisk. But this required
hardcoding partition name and we wanted to move away from that
as it did not work for pmem and loop devices. So we started using
following format instead.
units:sectors
start=2048, size=4096, Id=8e
As per latest sfdisk man page this should work but it does not seem to
work with sfdisk shipped with older util-linux (util-linux-2.23.2-33),
and we get errors like following.
sfdisk: trailing junk after number
sfdisk: bad input
But following format seems to work with old sfdisk format. So switch
to using that one.
units:sectors
2048, 4096, 8e
Signed-off-by: Vivek Goyal vgoyal@redhat.com