This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
bug: Change _build_model to take a dictionary. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since _wrap_on_message will always load the json data into a dictionary before passing it to the underlying implementation there was no need for _build_model to attempt to load the input as a json string.
mbarnes
reviewed
Sep 29, 2016
|
Will fix. |
|
⬆️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
_wrap_on_messagewill always load the json data into a dictionarybefore passing it to the underlying implementation there was no need for
_build_modelto attempt to load the input as a json string.