Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

atomic: honor UNINSTALL after stop of a container #1242

Conversation

giuseppe
Copy link
Collaborator

Honor the UNINSTALL label after the specified container was stopped.

Introduced by: 1895984

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1576285

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@TomSweeneyRedHat
Copy link

unhappy tests @giuseppe

@giuseppe giuseppe force-pushed the atomic-uninstall-call-label-after-stop branch from eddbe8c to 669e0eb Compare June 19, 2018 13:42
@giuseppe
Copy link
Collaborator Author

the failure is a flake

@giuseppe
Copy link
Collaborator Author

/cc @baude @rhatdan

@rhatdan
Copy link
Member

rhatdan commented Jun 20, 2018

bot, retest this please

@rhatdan
Copy link
Member

rhatdan commented Jun 20, 2018

LGTM
@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit 669e0eb has been approved by rhatdan

@rh-atomic-bot
Copy link

⌛ Testing commit 669e0eb with merge 3d5f4e0...

rh-atomic-bot pushed a commit that referenced this pull request Jun 20, 2018
Honor the UNINSTALL label after the specified container was stopped.

Introduced by: 1895984

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1576285

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1242
Approved by: rhatdan
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@giuseppe
Copy link
Collaborator Author

on centos there is a broken version of Skopeo that fails to pull system containers.

@giuseppe
Copy link
Collaborator Author

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit 669e0eb with merge 61b0fb7...

rh-atomic-bot pushed a commit that referenced this pull request Jun 23, 2018
Honor the UNINSTALL label after the specified container was stopped.

Introduced by: 1895984

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1576285

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1242
Approved by: rhatdan
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

Honor the UNINSTALL label after the specified container was stopped.

Introduced by: 1895984

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1576285

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the atomic-uninstall-call-label-after-stop branch from 669e0eb to d413cd6 Compare June 27, 2018 14:20
@giuseppe
Copy link
Collaborator Author

rebased on top of the CI fixes

@giuseppe
Copy link
Collaborator Author

giuseppe commented Jun 28, 2018

@rh-atomic-bot r=rhatdan

@rh-atomic-bot
Copy link

📌 Commit d413cd6 has been approved by rhatdan

@rh-atomic-bot
Copy link

⌛ Testing commit d413cd6 with merge b507039...

@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: rhatdan
Pushing b507039 to master...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants