Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

install: support multiple containers per image #1214

Closed

Conversation

giuseppe
Copy link
Collaborator

Change the install data format to keep a list of containers for each image installed, so that multiple containers for the same image can be installed and uninstalled.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1559935

@giuseppe giuseppe requested review from rhatdan and baude March 23, 2018 21:46
@giuseppe giuseppe force-pushed the install-data-multiple-containers branch 2 times, most recently from 0dff5e2 to f914062 Compare March 24, 2018 12:43
Change the install data format to keep a list of containers for each
image installed, so that multiple containers for the same image can be
installed and uninstalled.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1559935

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the install-data-multiple-containers branch from f914062 to 7bd37a8 Compare March 24, 2018 15:33
we should never release the lock until the entire read+write operation
is completed as the data might have changed between the read and the
write.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the install-data-multiple-containers branch from 7bd37a8 to 36b7a81 Compare March 24, 2018 15:58
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe changed the title [WIP] install: support multiple containers per image install: support multiple containers per image Mar 27, 2018
@giuseppe
Copy link
Collaborator Author

@baude does this look fine to you?

@baude
Copy link
Member

baude commented Mar 27, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit 36b7a81 has been approved by baude

@rh-atomic-bot
Copy link

⌛ Testing commit 36b7a81 with merge 6820f8f...

rh-atomic-bot pushed a commit that referenced this pull request Mar 27, 2018
we should never release the lock until the entire read+write operation
is completed as the data might have changed between the read and the
write.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1214
Approved by: baude
@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: baude
Pushing 6820f8f to master...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants