This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 142
install: support multiple containers per image #1214
Closed
giuseppe
wants to merge
2
commits into
projectatomic:master
from
giuseppe:install-data-multiple-containers
Closed
install: support multiple containers per image #1214
giuseppe
wants to merge
2
commits into
projectatomic:master
from
giuseppe:install-data-multiple-containers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
install-data-multiple-containers
branch
2 times, most recently
from
March 24, 2018 12:43
0dff5e2
to
f914062
Compare
Change the install data format to keep a list of containers for each image installed, so that multiple containers for the same image can be installed and uninstalled. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1559935 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
install-data-multiple-containers
branch
from
March 24, 2018 15:33
f914062
to
7bd37a8
Compare
we should never release the lock until the entire read+write operation is completed as the data might have changed between the read and the write. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
install-data-multiple-containers
branch
from
March 24, 2018 15:58
7bd37a8
to
36b7a81
Compare
rhatdan
reviewed
Mar 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
giuseppe
changed the title
[WIP] install: support multiple containers per image
install: support multiple containers per image
Mar 27, 2018
@baude does this look fine to you? |
📌 Commit 36b7a81 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 27, 2018
we should never release the lock until the entire read+write operation is completed as the data might have changed between the read and the write. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #1214 Approved by: baude
☀️ Test successful - status-papr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the install data format to keep a list of containers for each image installed, so that multiple containers for the same image can be installed and uninstalled.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1559935