Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

Do not call any selinux methods if selinux is disabled #1213

Closed
wants to merge 1 commit into from

Conversation

dirkboye
Copy link
Contributor

Description

selinux.setfscreatecon_raw(None) will throw an OSError exception if selinux is disabled.

Related Issue Numbers

#1211

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2018

bot, add author to whitelist

@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2018

bot, test pull request

@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2018

LGTM

@dirkboye
Copy link
Contributor Author

Hmm, I don't think the failure in centos/7/atomic is due to my pull request :-)

ERROR: test_find_image_on_registry (test_discovery.TestAtomicUtil)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/tmp/checkout/tests/unit/test_discovery.py", line 15, in test_find_image_on_registry
    self.assertEqual(ri.find_image_on_registry(), fq)
  File "Atomic/discovery.py", line 96, in find_image_on_registry
    raise RegistryInspectError("Unable to find {}".format(self.orig_input))
RegistryInspectError: Unable to find None

----------------------------------------------------------------------```

@rhatdan
Copy link
Member

rhatdan commented Mar 26, 2018

@baude @giuseppe PTAL

@giuseppe
Copy link
Collaborator

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit c006bda has been approved by giuseppe

@rh-atomic-bot
Copy link

⌛ Testing commit c006bda with merge cf17675...

rh-atomic-bot pushed a commit that referenced this pull request Mar 27, 2018
@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@giuseppe
Copy link
Collaborator

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit c006bda with merge 119f123...

@rh-atomic-bot
Copy link

☀️ Test successful - status-papr
Approved by: giuseppe
Pushing 119f123 to master...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants