Skip to content

Commit

Permalink
net: bridge: mcast: prepare add-router function for mcast router split
Browse files Browse the repository at this point in the history 
In preparation for the upcoming split of multicast router state into
their IPv4 and IPv6 variants move the protocol specific router list
and timer access to ip4 wrapper functions.

Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
@T-X @davem330
T-X authored and davem330 committed May 13, 2021
1 parent ee5fb22 commit d9b8c4d
Showing 1 changed file with 85 additions and 32 deletions.
117 changes: 85 additions & 32 deletions net/bridge/br_multicast.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ static const struct rhashtable_params br_sg_port_rht_params = {

static void br_multicast_start_querier(struct net_bridge *br,
struct bridge_mcast_own_query *query);
static void br_multicast_add_router(struct net_bridge *br,
struct net_bridge_port *port);
static void br_ip4_multicast_add_router(struct net_bridge *br,
struct net_bridge_port *port);
static void br_ip4_multicast_leave_group(struct net_bridge *br,
struct net_bridge_port *port,
__be32 group,
Expand Down Expand Up @@ -1687,9 +1687,8 @@ static void __br_multicast_enable_port(struct net_bridge_port *port)
#if IS_ENABLED(CONFIG_IPV6)
br_multicast_enable(&port->ip6_own_query);
#endif
if (port->multicast_router == MDB_RTR_TYPE_PERM &&
hlist_unhashed(&port->ip4_rlist))
br_multicast_add_router(br, port);
if (port->multicast_router == MDB_RTR_TYPE_PERM)
br_ip4_multicast_add_router(br, port);
}

void br_multicast_enable_port(struct net_bridge_port *port)
Expand Down Expand Up @@ -2653,45 +2652,86 @@ static void br_port_mc_router_state_change(struct net_bridge_port *p,
switchdev_port_attr_set(p->dev, &attr, NULL);
}

/*
* Add port to router_list
static struct net_bridge_port *
br_multicast_rport_from_node(struct net_bridge *br,
struct hlist_head *mc_router_list,
struct hlist_node *rlist)
{
return hlist_entry(rlist, struct net_bridge_port, ip4_rlist);
}

static struct hlist_node *
br_multicast_get_rport_slot(struct net_bridge *br,
struct net_bridge_port *port,
struct hlist_head *mc_router_list)

{
struct hlist_node *slot = NULL;
struct net_bridge_port *p;
struct hlist_node *rlist;

hlist_for_each(rlist, mc_router_list) {
p = br_multicast_rport_from_node(br, mc_router_list, rlist);

if ((unsigned long)port >= (unsigned long)p)
break;

slot = rlist;
}

return slot;
}

/* Add port to router_list
* list is maintained ordered by pointer value
* and locked by br->multicast_lock and RCU
*/
static void br_multicast_add_router(struct net_bridge *br,
struct net_bridge_port *port)
struct net_bridge_port *port,
struct hlist_node *rlist,
struct hlist_head *mc_router_list)
{
struct net_bridge_port *p;
struct hlist_node *slot = NULL;
struct hlist_node *slot;

if (!hlist_unhashed(&port->ip4_rlist))
if (!hlist_unhashed(rlist))
return;

hlist_for_each_entry(p, &br->ip4_mc_router_list, ip4_rlist) {
if ((unsigned long) port >= (unsigned long) p)
break;
slot = &p->ip4_rlist;
}
slot = br_multicast_get_rport_slot(br, port, mc_router_list);

if (slot)
hlist_add_behind_rcu(&port->ip4_rlist, slot);
hlist_add_behind_rcu(rlist, slot);
else
hlist_add_head_rcu(&port->ip4_rlist, &br->ip4_mc_router_list);
hlist_add_head_rcu(rlist, mc_router_list);

br_rtr_notify(br->dev, port, RTM_NEWMDB);
br_port_mc_router_state_change(port, true);
}

/* Add port to router_list
* list is maintained ordered by pointer value
* and locked by br->multicast_lock and RCU
*/
static void br_ip4_multicast_add_router(struct net_bridge *br,
struct net_bridge_port *port)
{
br_multicast_add_router(br, port, &port->ip4_rlist,
&br->ip4_mc_router_list);
}

static void br_multicast_mark_router(struct net_bridge *br,
struct net_bridge_port *port)
struct net_bridge_port *port,
struct timer_list *timer,
struct hlist_node *rlist,
struct hlist_head *mc_router_list)
{
unsigned long now = jiffies;

if (!port) {
if (br->multicast_router == MDB_RTR_TYPE_TEMP_QUERY) {
if (!timer_pending(&br->ip4_mc_router_timer))
if (!br_ip4_multicast_is_router(br) &&
!br_ip6_multicast_is_router(br))
br_mc_router_state_change(br, true);
mod_timer(&br->ip4_mc_router_timer,
now + br->multicast_querier_interval);
mod_timer(timer, now + br->multicast_querier_interval);
}
return;
}
Expand All @@ -2700,10 +2740,23 @@ static void br_multicast_mark_router(struct net_bridge *br,
port->multicast_router == MDB_RTR_TYPE_PERM)
return;

br_multicast_add_router(br, port);
br_multicast_add_router(br, port, rlist, mc_router_list);
mod_timer(timer, now + br->multicast_querier_interval);
}

static void br_ip4_multicast_mark_router(struct net_bridge *br,
struct net_bridge_port *port)
{
struct timer_list *timer = &br->ip4_mc_router_timer;
struct hlist_node *rlist = NULL;

if (port) {
timer = &port->ip4_mc_router_timer;
rlist = &port->ip4_rlist;
}

mod_timer(&port->ip4_mc_router_timer,
now + br->multicast_querier_interval);
br_multicast_mark_router(br, port, timer, rlist,
&br->ip4_mc_router_list);
}

static void
Expand All @@ -2717,7 +2770,7 @@ br_ip4_multicast_query_received(struct net_bridge *br,
return;

br_multicast_update_query_timer(br, query, max_delay);
br_multicast_mark_router(br, port);
br_ip4_multicast_mark_router(br, port);
}

#if IS_ENABLED(CONFIG_IPV6)
Expand All @@ -2732,7 +2785,7 @@ br_ip6_multicast_query_received(struct net_bridge *br,
return;

br_multicast_update_query_timer(br, query, max_delay);
br_multicast_mark_router(br, port);
br_ip4_multicast_mark_router(br, port);
}
#endif

Expand Down Expand Up @@ -3102,7 +3155,7 @@ static void br_multicast_pim(struct net_bridge *br,
pim_hdr_type(pimhdr) != PIM_TYPE_HELLO)
return;

br_multicast_mark_router(br, port);
br_ip4_multicast_mark_router(br, port);
}

static int br_ip4_multicast_mrd_rcv(struct net_bridge *br,
Expand All @@ -3113,7 +3166,7 @@ static int br_ip4_multicast_mrd_rcv(struct net_bridge *br,
igmp_hdr(skb)->type != IGMP_MRDISC_ADV)
return -ENOMSG;

br_multicast_mark_router(br, port);
br_ip4_multicast_mark_router(br, port);

return 0;
}
Expand Down Expand Up @@ -3181,7 +3234,7 @@ static void br_ip6_multicast_mrd_rcv(struct net_bridge *br,
if (icmp6_hdr(skb)->icmp6_type != ICMPV6_MRDISC_ADV)
return;

br_multicast_mark_router(br, port);
br_ip4_multicast_mark_router(br, port);
}

static int br_multicast_ipv6_rcv(struct net_bridge *br,
Expand Down Expand Up @@ -3526,11 +3579,11 @@ int br_multicast_set_port_router(struct net_bridge_port *p, unsigned long val)
case MDB_RTR_TYPE_PERM:
p->multicast_router = MDB_RTR_TYPE_PERM;
del_timer(&p->ip4_mc_router_timer);
br_multicast_add_router(br, p);
br_ip4_multicast_add_router(br, p);
break;
case MDB_RTR_TYPE_TEMP:
p->multicast_router = MDB_RTR_TYPE_TEMP;
br_multicast_mark_router(br, p);
br_ip4_multicast_mark_router(br, p);
break;
default:
goto unlock;
Expand Down

0 comments on commit d9b8c4d

Please sign in to comment.