Conversation
Move the pricing dialog to the Releases CTA for Phase Two and gate '/releases/new' routing on 'dspPlanSubscribed'. When Phase Two is off, preserve the legacy 'upload-song' flow and 'mint' toggle behavior in 'BasicSongDetails'/'BasicTrackDetails'.
|
Visit the studio preview URL for this PR 🚀 : https://981.artist.preview.newm.io/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request — Issue STUD-580
Overview
Move the DistributionPricingDialog flow to the Releases CTA for Phase Two. The dialog now appears on first interaction with the CTA when the user is not subscribed, and routes to the correct creation flow after acceptance. Phase One behavior remains unchanged.
Files Summary
Modified (4)
newm-web/apps/studio/src/pages/home/releases/Discography.tsxDistributionPricingDialogfor Phase Two only.newm-web/apps/studio/src/pages/home/releases/Releases.tsx/home/releases/newand/home/releases/new/track/newbased on flags and DSP subscription; routes to/home/upload-songwhen Phase Two is off.newm-web/apps/studio/src/pages/home/uploadSong/BasicSongDetails.tsxnewm-web/apps/studio/src/pages/home/releases/release/tracks/BasicTrackDetails.tsxImpact
/home/releases/newwhen user is not subscribed./home/releases/newis blocked unless subscribed.Testing
Related Issues
Dependencies
Demo
STUD-580-demo.mp4
Additional Notes
webStudioDisableDistributionAndSales=truekeeps users in/home/releases.webStudioAlbumPhaseTwo=falseroutes creation to/home/upload-songand uses legacy dialog flow.webStudioAlbumPhaseTwo=trueuses the new CTA dialog gating and/home/releases/newflow.--END--