Customizable keybindings

[EvanCarroll]

I know this is somewhat petty, but I would love to have Vim-esque keybindings

• H previous
• L next
• space play/pause (lock)
• S shuffle
• F11 maximize
• I (instead of Ctrl + B)

---

Ctrl + R, M would be great without Ctrl

---

Ctrl+S and Ctrl+E make sense to me as is.

---

I wouldn't push something like this hard, but it just seems like that would make it a lot more natural for those of geeks that use with lot of other stuff. Right now I'm running i3 (vim), tmux (vim), vim (vim), ranger (vim), and vlc (vim).

[iamnkc]

Hello, sir, I want to work on this feature. But, I am new to this. Can you provide some references so that I can start working on this feature.

Greetings @n-k-chilagani
The first step is building the software in your development environment.
Are you able to build from the master branch?
What operating system are you running?

[Chinmaygoyal]

Is the issue still up for grab?

[revmischa]

yep!

[Chinmaygoyal]

I am new to open source so it would be of great help if you could tell me where to start from.

[revmischa]

I would start here https://github.com/projectM-visualizer/projectm/blob/master/src/libprojectM/KeyHandler.cpp
And then look at the specific app you want to play with (-sdl is a good choice)

[shubhamrajeevpunekar]

If this issue is still up for grabs, can I have a go at it? So far, I have been able to build the master branch code from source and the key bindings for switching to next and previous preset are working in projectMSDL binary. However, the bindings for showing help, fps or stats have not worked, in the code I wasn't able to locate the functions for displaying these either. Could you point me in the right direction?

So you develop a strategic method for handling the needed changes. If you make a pull request on this repo, then myself and others can see your changes to make suggestions. Your changes do not have to be finished or working for you to open the pull request. The pull request creates a new ”ticket in the queue” for our continuous integration services. Most importantly: you have unlimited chances/retries to experiment with different ways to patch it. So there is no pressure to have a working patch to open the pull request. After your done experimenting, your patch must pass all the continuous integration tests. Then myself or one of the other devs here will merge your pull request. At that point you will become an official code contributor to projectm code. What do you think?

…

On Oct 15, 2019, at 3:55 PM, srp3003 ***@***.***> wrote:  If this issue is still up for grabs, can I have a go at it? So far, I have been able to build the master branch code from source and the key bindings for switching to next and previous preset are working in projectMSDL binary. However, the bindings for showing help, fps or stats have not worked, in the code I wasn't able to locate the functions for displaying these either. Could you point me in the right direction? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[revmischa]

@srp3003 sure go for it. Whatever is in KeyHandler.cpp is what is shared from the core library.

	case PROJECTM_KEYDOWN:

	  switch( keycode )
	    {
	    case PROJECTM_K_UP:
            beatDetect->beat_sensitivity += 0.25;
			if (beatDetect->beat_sensitivity > 5.0) beatDetect->beat_sensitivity = 5.0;
	      break;
	    case PROJECTM_K_DOWN:
            beatDetect->beat_sensitivity -= 0.25;
			if (beatDetect->beat_sensitivity < 0) beatDetect->beat_sensitivity = 0;
	      break;
		case PROJECTM_K_h:
 		  renderer->showhelp = !renderer->showhelp;
	      renderer->showstats= false;
	      renderer->showfps=false;
	    case PROJECTM_K_F1:
	      renderer->showhelp = !renderer->showhelp;
	      renderer->showstats=false;
	      renderer->showfps=false;
	      break;
	    case PROJECTM_K_y:
		this->setShuffleEnabled(!this->isShuffleEnabled());
		 break;

	    case PROJECTM_K_F5:
	      if (!renderer->showhelp)
		      renderer->showfps = !renderer->showfps;
	      break;

etc...

@coast77777777777 sounds great. i think the appveyor build is broken right now tho.

Haha ok I will try to fix it

…

On Oct 16, 2019, at 4:28 AM, Mischa Spiegelmock ***@***.***> wrote:  @srp3003 sure go for it. Whatever is in KeyHandler.cpp is what is shared from the core library. case PROJECTM_KEYDOWN: switch( keycode ) { case PROJECTM_K_UP: beatDetect->beat_sensitivity += 0.25; if (beatDetect->beat_sensitivity > 5.0) beatDetect->beat_sensitivity = 5.0; break; case PROJECTM_K_DOWN: beatDetect->beat_sensitivity -= 0.25; if (beatDetect->beat_sensitivity < 0) beatDetect->beat_sensitivity = 0; break; case PROJECTM_K_h: renderer->showhelp = !renderer->showhelp; renderer->showstats= false; renderer->showfps=false; case PROJECTM_K_F1: renderer->showhelp = !renderer->showhelp; renderer->showstats=false; renderer->showfps=false; break; case PROJECTM_K_y: this->setShuffleEnabled(!this->isShuffleEnabled()); break; case PROJECTM_K_F5: if (!renderer->showhelp) renderer->showfps = !renderer->showfps; break; etc... @coast77777777777 sounds great. i think the appveyor build is broken right now tho. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[shubhamrajeevpunekar]

@coast77777777777, that sounds great! Especially your point about having unlimited chances really takes the pressure off!

@revmischa, I had the following questions:

• which of the shortcuts should I try to implement?
• Are Ctrl + B, Ctrl + R, Crtl + M, Ctrl+S and Ctrl + E assigned for some operation? I couldn't see any feedback on hitting them in projectMSDL binary.
• Should I reassign "show help" to H instead of h? That will leave h and l free for previous and next.

[revmischa]

My advice is to mostly ignore the original text of this issue and do whatever is most compatible/similar to Milkdrop - http://wiki.winamp.com/wiki/MilkDrop_Unleashed_Guide#Usage