refactor: remove usage of goto in the image store

[andaaron]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (66bb834) to head (549859e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2969      +/-   ##
==========================================
+ Coverage   91.11%   91.82%   +0.70%     
==========================================
  Files         184      184              
  Lines       33934    25459    -8475     
==========================================
- Hits        30920    23377    -7543     
+ Misses       2274     1342     -932     
  Partials      740      740              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rchincha]

lgtm

but why make this change at all?

[andaaron]

Because it was very confusing for me as a developer reading the code.
I was troubleshooting an issue related to some of the calls made from this function, and it took me over an hour to notice we had a loop and those functions were called multiple times.

In any case don't merge this. I prefer to proceed with the PR also handling the locks.