fix(storage): handle dedupe disabled in GetAllDedupeReposCandidates()

pkg/api/config/config.go

@@ -340,6 +340,10 @@ func (c *Config) IsLdapAuthEnabled() bool {
 	return false
 }
 
+func (c *Config) IsAuthzEnabled() bool {
+	return c.HTTP.AccessControl != nil
+}
+
 func (c *Config) IsMTLSAuthEnabled() bool {
 	if c.HTTP.TLS != nil &&
 		c.HTTP.TLS.Key != "" &&

pkg/api/routes.go

@@ -879,13 +879,11 @@
 ) (bool, error) {
 	canMount := true
 
-	// authz enabled
 	if userAc != nil {
 		canMount = false
 
 		repos, err := imgStore.GetAllDedupeReposCandidates(digest)
 		if err != nil {
-			// first write
 			return false, err
 		}
 
@@ -943,9 +941,12 @@
 		return
 	}
 
-	userCanMount, err := canMount(userAc, imgStore, digest)
-	if err != nil {
-		rh.c.Log.Error().Err(err).Msg("unexpected error")
+	userCanMount := true
+	if rh.c.Config.IsAuthzEnabled() {
+		userCanMount, err = canMount(userAc, imgStore, digest)
+		if err != nil {
+			rh.c.Log.Error().Err(err).Msg("unexpected error")
+		}
 	}
 
 	var blen int64
@@ -963,7 +964,7 @@
 
 	if err != nil {
 		details := zerr.GetDetails(err)
-		if errors.Is(err, zerr.ErrBadBlobDigest) { //nolint:gocritic // errorslint conflicts with gocritic:IfElseChain
+		if errors.Is(err, zerr.ErrBadBlobDigest) { //nolint:gocritic,dupl // errorslint conflicts with gocritic:IfElseChain
 			details["digest"] = digest.String()
 			e := apiErr.NewError(apiErr.DIGEST_INVALID).AddDetail(details)
 			zcommon.WriteJSON(response, http.StatusBadRequest, apiErr.NewErrorList(e))
@@ -1254,9 +1255,12 @@
 			return
 		}
 
-		userCanMount, err := canMount(userAc, imgStore, mountDigest)
-		if err != nil {
-			rh.c.Log.Error().Err(err).Msg("unexpected error")
+		userCanMount := true
+		if rh.c.Config.IsAuthzEnabled() {
+			userCanMount, err = canMount(userAc, imgStore, mountDigest)
+			if err != nil {
+				rh.c.Log.Error().Err(err).Msg("unexpected error")
+			}
 		}
 
 		// zot does not support cross mounting directly and do a workaround creating using hard link.

pkg/storage/imagestore/imagestore.go

@@ -69,7 +69,7 @@
 func NewImageStore(rootDir string, cacheDir string, dedupe, commit bool, log zlog.Logger,
 	metrics monitoring.MetricServer, linter common.Lint, storeDriver storageTypes.Driver, cacheDriver cache.Cache,
 ) storageTypes.ImageStore {
 	if err := storeDriver.EnsureDir(rootDir); err != nil {
 		log.Error().Err(err).Str("rootDir", rootDir).Msg("failed to create root dir")
 
 		return nil
@@ -127,13 +127,13 @@
 func (is *ImageStore) initRepo(name string) error {
 	repoDir := path.Join(is.rootDir, name)
 
 	if !utf8.ValidString(name) {
 		is.log.Error().Msg("invalid UTF-8 input")
 
 		return zerr.ErrInvalidRepositoryName
 	}
 
 	if !zreg.FullNameRegexp.MatchString(name) {
 		is.log.Error().Str("repository", name).Msg("invalid repository name")
 
 		return zerr.ErrInvalidRepositoryName
@@ -141,14 +141,14 @@
 
 	// create "blobs" subdir
 	err := is.storeDriver.EnsureDir(path.Join(repoDir, ispec.ImageBlobsDir))
 	if err != nil {
 		is.log.Error().Err(err).Str("repository", name).Str("dir", repoDir).Msg("failed to create blobs subdir")
 
 		return err
 	}
 	// create BlobUploadDir subdir
 	err = is.storeDriver.EnsureDir(path.Join(repoDir, storageConstants.BlobUploadDir))
 	if err != nil {
 		is.log.Error().Err(err).Msg("failed to create blob upload subdir")
 
 		return err
@@ -156,17 +156,17 @@
 
 	// "oci-layout" file - create if it doesn't exist
 	ilPath := path.Join(repoDir, ispec.ImageLayoutFile)
 	if _, err := is.storeDriver.Stat(ilPath); err != nil {
 		il := ispec.ImageLayout{Version: ispec.ImageLayoutVersion}
 
 		buf, err := json.Marshal(il)
 		if err != nil {
 			is.log.Error().Err(err).Msg("failed to marshal JSON")
 
 			return err
 		}
 
 		if _, err := is.storeDriver.WriteFile(ilPath, buf); err != nil {
 			is.log.Error().Err(err).Str("file", ilPath).Msg("failed to write file")
 
 			return err
@@ -175,12 +175,12 @@
 
 	// "index.json" file - create if it doesn't exist
 	indexPath := path.Join(repoDir, ispec.ImageIndexFile)
 	if _, err := is.storeDriver.Stat(indexPath); err != nil {
 		index := ispec.Index{}
 		index.SchemaVersion = 2
 
 		buf, err := json.Marshal(index)
 		if err != nil {
 			is.log.Error().Err(err).Msg("failed to marshal JSON")
 
 			return err
@@ -1121,6 +1121,10 @@
 		return nil, err
 	}
 
+	if is.cache == nil {
+		return nil, nil
+	}
+
 	is.RLock(&lockLatency)
 	defer is.RUnlock(&lockLatency)