Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show brief package list in image CVE listings #2338

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

vrajashkr
Copy link
Contributor

What type of PR is this?
feature

Which issue does this PR fix:
Towards #2175
Addresses this comment: #2175 (comment)

What does this PR do / Why do we need it:
This PR adds a brief listing of vulnerable packages to the CVE list view. This will give the user an overall picture of the impacted packages. It displays the name, path (if available), installed version, and fixed version.

Testing done on this change:
Image with few vulnerable packages:
Screenshot from 2024-03-24 12-30-55

Image with many vulnerable packages with and without paths:
Screenshot from 2024-03-24 12-31-47

Image with smaller terminal window displaying line wrapping (Gnome terminal):
Screenshot from 2024-03-24 12-32-56

Automation added to e2e:
N/A

Will this break upgrades or downgrades?
No, it is not expected to impact upgrade or downgrades as the data is already available via GraphQL and this is only a presentation change to add more data.

Does this PR introduce any user-facing change?:
Yes

Users can now view a brief vulnerable package list for each CVE in the CVE list view in non-verbose mode.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Rajashekar <vrajashe@cisco.com>
@vrajashkr vrajashkr force-pushed the feat/package-list-for-cve branch from a7841ae to 030b704 Compare March 24, 2024 09:08
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (4105f12) to head (030b704).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
+ Coverage   92.85%   92.86%   +0.01%     
==========================================
  Files         167      167              
  Lines       22038    22057      +19     
==========================================
+ Hits        20463    20484      +21     
+ Misses        982      980       -2     
  Partials      593      593              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit aa53782 into project-zot:main Mar 25, 2024
35 checks passed
@vrajashkr vrajashkr deleted the feat/package-list-for-cve branch March 25, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants