Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added swagger doc generation for mgmt and userprefs #1530

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

aokirisaki
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Makefile Outdated Show resolved Hide resolved
pkg/extensions/extension_userprefs.go Outdated Show resolved Hide resolved
swagger/docs.go Outdated Show resolved Hide resolved
@aokirisaki aokirisaki force-pushed the swagger-doc branch 2 times, most recently from f7dec6e to 7b3ebc8 Compare June 19, 2023 09:31
andaaron
andaaron previously approved these changes Jun 19, 2023
swagger/docs.go Outdated Show resolved Hide resolved
swagger/docs.go Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1530 (bc0ec42) into main (fc6d635) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   91.19%   91.16%   -0.03%     
==========================================
  Files         114      114              
  Lines       22757    22757              
==========================================
- Hits        20753    20747       -6     
- Misses       1495     1500       +5     
- Partials      509      510       +1     
Impacted Files Coverage Δ
pkg/extensions/extension_mgmt.go 90.24% <ø> (ø)
pkg/extensions/extension_userprefs.go 90.72% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Lisca Ana-Roberta <ana.kagome@yahoo.com>
@rchincha rchincha merged commit aa16c95 into project-zot:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants