feat(sync): sync references(signatures/artifacts) recursively #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
andaaron
reviewed
Jun 8, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
from
b2bd207
to
408adf3
Compare
andaaron
reviewed
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 91.11% 91.17% +0.06%
==========================================
Files 114 114
Lines 22751 22749 -2
==========================================
+ Hits 20729 20741 +12
+ Misses 1510 1498 -12
+ Partials 512 510 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
3 times, most recently
from
5470f38
to
b873e40
Compare
andaaron
previously approved these changes
Jun 8, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
from
b873e40
to
54fc976
Compare
andaaron
previously approved these changes
Jun 9, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
from
54fc976
to
e70d0b2
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
from
e70d0b2
to
d71e5eb
Compare
andaaron
previously approved these changes
Jun 12, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
4 times, most recently
from
d3dfa9a
to
4587f87
Compare
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
2 times, most recently
from
7321edf
to
cff63f4
Compare
|
added test for infinite loops: image -> sbom A -> oci ref -> sbom A |
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
3 times, most recently
from
2225730
to
95950f5
Compare
andaaron
previously approved these changes
Jun 16, 2023
sync now also pulls chained artifacts recursively eg: image->sbom->sbom signature image->artifact->artifact Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
sync_recursive_references
branch
from
95950f5
to
96bd44b
Compare
andaaron
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
#1334
What does this PR do / Why do we need it:
sync now also pulls chained artifacts recursively
eg:
image->sbom->sbom signature
image->artifact->artifact
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
added chained artifacts in sync_test.go/TestSignatures()
Will this break upgrades or downgrades?
no
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.