fix(cve): Fix CVE scanning in images containing Jar files #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
force-pushed
the
java
branch
2 times, most recently
from
8cf9eb7
to
08d27ec
Compare
andaaron
commented
May 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #1475 +/- ##
=======================================
Coverage 91.13% 91.14%
=======================================
Files 114 114
Lines 22726 22751 +25
=======================================
+ Hits 20711 20736 +25
Misses 1504 1504
Partials 511 511
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andaaron
force-pushed
the
java
branch
3 times, most recently
from
83703f0
to
3b6cdbf
Compare
andaaron
requested review from
shimish2,
eusebiu-constantin-petu-dbk and
rchincha
as code owners
andaaron
commented
May 29, 2023
andaaron
force-pushed
the
java
branch
3 times, most recently
from
691ae11
to
9c868a4
Compare
See project-zot#1428 Looks like Trivy uses a separate DB for jar scanning. This DB is very large and takes additional time to download It has 430 MB at download time, and will grow afterwards sqlite is a dependency for trivy to use this DB Also decrease priority of dedupe tasks, since the Trivy download task was delayed too much after the server started. Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1428
Looks like Trivy uses a separate DB for jar scanning. This DB is very large and takes additional time to download It has 430 MB at download time, and will grow afterwards
sqlite is a dependency for trivy to use this DB
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.