Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): fixed way of updating repodb when syncing a signature #1439

Merged

Conversation

laurentiuNiculae
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurentiuNiculae laurentiuNiculae force-pushed the fix-sync-repodb-signatures branch 2 times, most recently from 4f1799d to 37b5c53 Compare May 11, 2023 11:22
@laurentiuNiculae laurentiuNiculae marked this pull request as ready for review May 12, 2023 07:07
@laurentiuNiculae laurentiuNiculae force-pushed the fix-sync-repodb-signatures branch 5 times, most recently from 45f2c81 to 7671421 Compare May 12, 2023 13:57
andaaron
andaaron previously approved these changes May 12, 2023
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1439 (071d0b2) into main (bf4b2b9) will decrease coverage by 0.01%.
The diff coverage is 92.96%.

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
- Coverage   90.78%   90.77%   -0.01%     
==========================================
  Files          99       99              
  Lines       22191    22158      -33     
==========================================
- Hits        20146    20115      -31     
- Misses       1525     1526       +1     
+ Partials      520      517       -3     
Impacted Files Coverage Δ
pkg/test/common.go 84.74% <50.00%> (-0.16%) ⬇️
pkg/extensions/sync/signatures.go 86.86% <87.50%> (-1.00%) ⬇️
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go 89.29% <93.33%> (+0.03%) ⬆️
pkg/api/routes.go 95.14% <100.00%> (+0.67%) ⬆️
pkg/extensions/sync/utils.go 88.01% <100.00%> (-1.08%) ⬇️
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go 93.29% <100.00%> (-0.02%) ⬇️
pkg/meta/repodb/storage_parsing.go 100.00% <100.00%> (ø)
pkg/meta/update.go 99.04% <100.00%> (-0.12%) ⬇️
pkg/storage/common.go 96.53% <100.00%> (+0.56%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rchincha
rchincha previously approved these changes May 12, 2023
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha
Copy link
Contributor

There are conflicts

@andaaron andaaron linked an issue May 12, 2023 that may be closed by this pull request
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@andaaron andaaron merged commit 7bf40e7 into project-zot:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Repodb: synced cosign signatures are saved as images
3 participants