fix(search): added the missing headers for allow methods and allowed h… #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
force-pushed
the
fix-allow-methods
branch
2 times, most recently
from
719c6ab
to
2452ffa
Compare
andaaron
approved these changes
May 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
- Coverage 90.79% 90.75% -0.05%
==========================================
Files 99 99
Lines 22137 22153 +16
==========================================
+ Hits 20099 20104 +5
- Misses 1520 1528 +8
- Partials 518 521 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
laurentiuNiculae
requested review from
rchincha and
eusebiu-constantin-petu-dbk
as code owners
- added allow methods and allowed headers Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
laurentiuNiculae
force-pushed
the
fix-allow-methods
branch
from
2452ffa
to
e8e2c59
Compare
andaaron
changed the title
andaaron
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eaders
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.