Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(userpreferences): update allowed methods header for user prefere… #1430

Merged
merged 1 commit into from
May 10, 2023

Conversation

laurentiuNiculae
Copy link
Contributor

…nces routes

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurentiuNiculae laurentiuNiculae force-pushed the add-allow-method branch 2 times, most recently from de62bfd to 4921920 Compare May 8, 2023 15:29
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1430 (f7e83ff) into main (449f0d0) will increase coverage by 0.02%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   90.68%   90.70%   +0.02%     
==========================================
  Files          99       99              
  Lines       22390    22443      +53     
==========================================
+ Hits        20305    20358      +53     
  Misses       1558     1558              
  Partials      527      527              
Impacted Files Coverage Δ
pkg/api/controller.go 92.51% <ø> (-0.04%) ⬇️
pkg/api/routes.go 94.44% <93.87%> (-0.07%) ⬇️
pkg/api/authn.go 90.72% <100.00%> (+0.11%) ⬆️
pkg/api/authz.go 96.47% <100.00%> (+0.06%) ⬆️
pkg/common/common.go 93.25% <100.00%> (+0.07%) ⬆️
pkg/extensions/extension_userprefs.go 90.81% <100.00%> (+0.59%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…nces routes

Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 3be690c into project-zot:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS: include method PUT in Access-Control-Methods for userprefs extension
3 participants