Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): skip non distributable layers #1421

Conversation

eusebiu-constantin-petu-dbk
Copy link
Collaborator

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1421 (31fbcf2) into main (5fcf01d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 31fbcf2 differs from pull request most recent head 898e0ac. Consider uploading reports for the commit 898e0ac to get more accurate results

@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files          99       99           
  Lines       22338    22340    +2     
=======================================
+ Hits        20261    20263    +2     
  Misses       1552     1552           
  Partials      525      525           
Impacted Files Coverage Δ
pkg/extensions/sync/utils.go 89.87% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit e299ae1 into project-zot:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants