Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql & repodb): add info about signature validity #1344

Merged
merged 1 commit into from
May 24, 2023

Conversation

Andreea-Lupu
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the behavior in case we run zot with dynamodb configuration? What would the SignatureSummary contain?

pkg/extensions/search/convert/repodb.go Outdated Show resolved Hide resolved
pkg/meta/update.go Show resolved Hide resolved
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go Outdated Show resolved Hide resolved
pkg/meta/repodb/repodb.go Outdated Show resolved Hide resolved
pkg/meta/repodb/repodbfactory/repodb_factory.go Outdated Show resolved Hide resolved
@Andreea-Lupu Andreea-Lupu force-pushed the signatures_validity branch 4 times, most recently from 8dd7b4c to 08cb7cc Compare April 12, 2023 17:09
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1344 (615977a) into main (6e6ffe8) will increase coverage by 0.10%.
The diff coverage is 96.65%.

@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
+ Coverage   90.82%   90.93%   +0.10%     
==========================================
  Files          99      102       +3     
  Lines       22177    22604     +427     
==========================================
+ Hits        20143    20554     +411     
- Misses       1519     1528       +9     
- Partials      515      522       +7     
Impacted Files Coverage Δ
pkg/meta/signatures/cosign.go 85.24% <85.24%> (ø)
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go 89.66% <96.51%> (+0.36%) ⬆️
pkg/meta/signatures/notation.go 97.08% <97.08%> (ø)
pkg/extensions/search/convert/repodb.go 97.77% <100.00%> (+0.15%) ⬆️
pkg/extensions/sync/signatures.go 86.86% <100.00%> (ø)
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go 93.51% <100.00%> (+0.03%) ⬆️
pkg/meta/repodb/repodbfactory/repodb_factory.go 91.83% <100.00%> (+0.34%) ⬆️
pkg/meta/repodb/storage_parsing.go 100.00% <100.00%> (ø)
pkg/meta/signatures/signatures.go 100.00% <100.00%> (ø)
pkg/meta/update.go 100.00% <100.00%> (+0.95%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andaaron
andaaron previously approved these changes Apr 19, 2023
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should wait on this PR until after notation switches to image manifests?

pkg/meta/update_test.go Outdated Show resolved Hide resolved
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go Outdated Show resolved Hide resolved
@Andreea-Lupu Andreea-Lupu force-pushed the signatures_validity branch 7 times, most recently from f31e03b to a1387a4 Compare May 19, 2023 09:56
pkg/extensions/search/convert/repodb.go Outdated Show resolved Hide resolved
pkg/meta/repodb/storage_parsing.go Outdated Show resolved Hide resolved
pkg/meta/signatures/cosign.go Outdated Show resolved Hide resolved
pkg/meta/signatures/notation.go Outdated Show resolved Hide resolved
pkg/meta/signatures/signatures.go Outdated Show resolved Hide resolved
@Andreea-Lupu Andreea-Lupu force-pushed the signatures_validity branch 2 times, most recently from b17b2b9 to d25f159 Compare May 19, 2023 17:32
errors/errors.go Outdated Show resolved Hide resolved
@Andreea-Lupu Andreea-Lupu force-pushed the signatures_validity branch 2 times, most recently from d7b410f to 752c671 Compare May 23, 2023 08:30
Signed-off-by: Andreea-Lupu <andreealupu1470@yahoo.com>
@andaaron andaaron linked an issue May 24, 2023 that may be closed by this pull request
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store cosign signature information in RepoDB
3 participants