-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql & repodb): add info about signature validity #1344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the behavior in case we run zot with dynamodb configuration? What would the SignatureSummary contain?
8dd7b4c
to
08cb7cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
+ Coverage 90.82% 90.93% +0.10%
==========================================
Files 99 102 +3
Lines 22177 22604 +427
==========================================
+ Hits 20143 20554 +411
- Misses 1519 1528 +9
- Partials 515 522 +7
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
08cb7cc
to
d97be30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d97be30
to
abd6eda
Compare
abd6eda
to
af49a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should wait on this PR until after notation switches to image manifests?
f31e03b
to
a1387a4
Compare
b17b2b9
to
d25f159
Compare
d7b410f
to
752c671
Compare
Signed-off-by: Andreea-Lupu <andreealupu1470@yahoo.com>
752c671
to
615977a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.