-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sync): use task scheduler #1301
refactor(sync): use task scheduler #1301
Conversation
todo:
fixed |
1ee957f
to
76321c6
Compare
1041316
to
18f3253
Compare
Codecov Report
@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 90.99% 91.10% +0.10%
==========================================
Files 104 114 +10
Lines 22620 22726 +106
==========================================
+ Hits 20583 20704 +121
+ Misses 1518 1510 -8
+ Partials 519 512 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
18f3253
to
bd7bec9
Compare
8787788
to
5dc2381
Compare
fe8d876
to
f0ea7b4
Compare
34b8f08
to
ea54ba5
Compare
When syncing to an existing local repo, we may clobber "latest", do sane things and log |
For a given/existing repo, sync and clients may both be writers to the same repo, so locking? |
Recursive download of references (I expect two levels) |
13c1c19
to
88d864c
Compare
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
88d864c
to
e0a5c18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.