Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sync): use task scheduler #1301

Merged
merged 1 commit into from
May 31, 2023

Conversation

eusebiu-constantin-petu-dbk
Copy link
Collaborator

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@eusebiu-constantin-petu-dbk
Copy link
Collaborator Author

eusebiu-constantin-petu-dbk commented Mar 24, 2023

todo:

  1. reload sync config
  2. rebase laurentiu changes for repodb

fixed

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1301 (e0a5c18) into main (e148343) will increase coverage by 0.10%.
The diff coverage is 91.88%.

@@            Coverage Diff             @@
##             main    #1301      +/-   ##
==========================================
+ Coverage   90.99%   91.10%   +0.10%     
==========================================
  Files         104      114      +10     
  Lines       22620    22726     +106     
==========================================
+ Hits        20583    20704     +121     
+ Misses       1518     1510       -8     
+ Partials      519      512       -7     
Impacted Files Coverage Δ
pkg/extensions/sync/on_demand_disabled.go 0.00% <0.00%> (ø)
pkg/extensions/sync/remote.go 80.26% <80.26%> (ø)
pkg/extensions/sync/references/oras.go 82.60% <82.60%> (ø)
pkg/extensions/sync/references/oci.go 83.76% <83.76%> (ø)
pkg/common/common.go 94.11% <87.50%> (+0.05%) ⬆️
pkg/extensions/sync/references/cosign.go 90.90% <90.90%> (ø)
pkg/extensions/sync/local.go 91.32% <91.32%> (ø)
pkg/storage/local/local.go 81.83% <91.66%> (-0.14%) ⬇️
pkg/extensions/sync/oci_layout.go 91.89% <91.89%> (ø)
pkg/extensions/sync/sync.go 91.17% <92.59%> (-3.67%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rchincha
Copy link
Contributor

When syncing to an existing local repo, we may clobber "latest", do sane things and log

@rchincha
Copy link
Contributor

For a given/existing repo, sync and clients may both be writers to the same repo, so locking?

@rchincha
Copy link
Contributor

Recursive download of references (I expect two levels)

pkg/api/routes.go Outdated Show resolved Hide resolved
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 612a12e into project-zot:main May 31, 2023
@andaaron andaaron linked an issue May 31, 2023 that may be closed by this pull request
@andaaron andaaron linked an issue Jun 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zot sync: update sync logic to use the task scheduler [Feat]: organize sync per media-type
3 participants