Issue SB-11205 fix: adding ets fixes error correction from server ts #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallakartheekreddy
requested changes
Mar 27, 2019
js/dist/index.js
Outdated
|
|
||
| var calculateTsDifference = function (tsObj) { | ||
| var tsDiff = 0; | ||
| if (tsObj && tsObj.serverEts) { |
There was a problem hiding this comment.
fix indentation issue
SanthoshVasabhaktula
requested changes
Mar 27, 2019
| instance.getEvent = function(eventId, data) { | ||
| telemetryInstance.telemetryEnvelop.eid = eventId; | ||
| telemetryInstance.telemetryEnvelop.ets = (new Date()).getTime(); | ||
| telemetryInstance.telemetryEnvelop.ets = new Number(new Date().getTime()) + Telemetry.config.tsDiff; |
There was a problem hiding this comment.
Is the cast to Number necessary?
| spyOn(telemetryObj, 'initialize').and.callThrough(); | ||
| module = 'undefined' | ||
| console.log("Module", module) | ||
| config.pdata = { "id": "in.ekstep", "ver": "1.0", "pid": "" } |
There was a problem hiding this comment.
Remove the reference to "in.ekstep" use "org.sunbird" instead
| config.channel = 'in.ekstep.' | ||
| config.timeStampData = {serverTime: new Date(),localTime: localTime} | ||
| telemetryObj.initialize(config); | ||
| expect(EkTelemetry.config.tsDiff).not.toEqual(0) |
There was a problem hiding this comment.
Not enough assertions. Assert for the exact value by setting the server time to a fixed value as well. Also assert for the right event timestamp by firing an event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://project-sunbird.atlassian.net/browse/SB-11205