Add menu state information #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To test this, you'll want to use the Ishiiruka that supports it: Libmelee can then be used to finish the loop: |
JLaferri
reviewed
Jun 29, 2020
Recording/Recording.s
Outdated
| .set CMD_ITEM, 0x3B | ||
| .set CMD_FRAME_BOOKEND, 0x3C | ||
| .set CMD_GAME_END, 0x39 | ||
| .set CMD_MENU_FRAME, 0x3E |
Member
There was a problem hiding this comment.
Maybe put this under the command count and add comment that says these commands are not executed while in a recorded game
- Only sent when NOT in game
- Avoids segfaulting on trying to read them
- Was reading some from heap addresses, was fragile
Contributor
Author
|
- scene sub-menu - menu selection index - both at static locations
- Added extra conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not part of SLP file
Gets written to EXI device for slippicom server