Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple update of the ledger-hq package resolved windows 10 problem #138

Merged

Conversation

Arrowana
Copy link
Contributor

@Arrowana Arrowana commented Mar 11, 2021

Before:
When clicking Import hardware wallet and was getting "received error when attempting to connect ledger: NetworkError: Unable to reset the device.". While the ledger nano was connected and in the Solana app.

With this PR:
I can see the account and the balance after clicking Import hardware wallet
I can send funds to another account, signing the transaction through the ledger.

Step 2:
In another PR, transform console.log into toast so it doesn't silently fails if it does. Other errors seem to result in resonable toast

Fixes #97

@nathanielparke nathanielparke self-assigned this Mar 11, 2021
@nathanielparke
Copy link
Contributor

Nice! Thank you for the PR. This does indeed seem to fix the issues observed on Windows so I will go ahead and merge.

@nathanielparke nathanielparke merged commit 467afee into project-serum:master Mar 11, 2021
@0xTimepunk
Copy link

This is not working yet.

The ledger connects, but I cannot create any SPL token with it.

It gives this error:

Ledger device: UNKNOWN_ERROR (0x6808)

image

@nathanielparke
Copy link
Contributor

Have you enabled blind signing on your ledger device?

@Arrowana
Copy link
Contributor Author

Arrowana commented Mar 11, 2021

@nathanielparke I have not enabled blind signing, I did see the transaction on my device when sending and approved it. However, I tried only a SOL transaction from account A (Ledger nano) to account B (web wallet). I'll try creating a token account tonight to see if the outcome is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When full ledger support?
3 participants