Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene graph implementation (continued #2) #239

Merged
merged 30 commits into from
Sep 23, 2020
Merged

Scene graph implementation (continued #2) #239

merged 30 commits into from
Sep 23, 2020

Conversation

zmughal
Copy link
Member

@zmughal zmughal commented Sep 11, 2020 •
edited
Loading

Connects with: Intertangle/p5-Intertangle-Jacquard#4, Intertangle/p5-Intertangle-Punchcard#2, Intertangle/p5-Intertangle-Taffeta#4, Intertangle/p5-Intertangle-Taffeta#5

Continued from #238.

Steps for prototype:

  • Implement changing № of columns for grid displayed on Cairo surface.
  • Implement continuous / non-continuous view while keeping previous features.
  • Implement zooming while keeping previous features.

@zmughal zmughal added this to the curie v0.005 milestone Sep 11, 2020
@coveralls
Copy link

coveralls commented Sep 11, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-13.08%) to 79.849% when pulling 89c5acf on scenegraph-curie-impl into 726136c on master.

@zmughal
Move JacquardCanvas from test to component
c9f796c
@zmughal
Move canvas mouse and scroll features to roles
d361f80
@zmughal
Separate Mouse features into roles
de0d2b3
@zmughal
Move scene graph creation to class
9066976
@zmughal
Split setting internal data from constructor
7bc84da
@zmughal
Fix indent for JacquardCanvas
5b00073
@zmughal
Default data for canvas
b171b36
@zmughal
Use scenegraph (first try)
57539cc
@zmughal
Remove some old page drawing code
cb8caba
@zmughal
Hook up some drawing area code to new canvas
5bf2015
@zmughal
Remove old roles and role implementations
f0876d9
@zmughal
Update view update signals
8726d40
@zmughal
Update subview index for change in page number
6171231
@zmughal
Add method to scroll canvas to a page number
e5a26ce
@zmughal
Add view parameter for scenegraph factory
dcc5c1a
@zmughal
Use placeholder text to indicate current page on scroll
4bc952f
@zmughal
Set page number only if viewport changes
a6a772f
@zmughal
Extract variable for zoom level
fdae205
@zmughal
Split signals
abbf5f3 
- `view-changed` (from View) -> `update-view` (from ViewManager)

- `view-changed` (in View) is separate from `scroll-to-page` (in View)
@zmughal
Use viewport page range for placeholder text
55a591a 
And only change page number when outside of range
@zmughal
Set adjustment step increments
f319ae4
@zmughal
Accessor for zoom level
8c70d9a
@zmughal
Conditional for Taffeta: PDF | CairoImageSurface rendered page
a1f30ec
@zmughal
Update test for new interface
2bb08e4
@zmughal
Extract extent bbox code to methods
13aa267
@zmughal
Use canvas methods for TTS sentence highlighting
c210727
@zmughal
Copy link
Member Author

zmughal commented Sep 22, 2020

curie-scenegraph-curie-impl-2020-09-22_16 52 11

Check old features:

  • Continuous view
  • Zoom
  • Columns
  • Sidebar - jump to page
  • Page number text field - go to page
  • Highlight TTS sentence

@zmughal
Copy link
Member Author

zmughal commented Sep 23, 2020

The drop in coverage is due to not testing the mouse interaction code. This can be ignored for now and tested later.

@zmughal zmughal mentioned this pull request Sep 23, 2020
Open
@zmughal zmughal marked this pull request as ready for review September 23, 2020 17:34
@zmughal zmughal merged commit e0e3033 into master Sep 23, 2020
@zmughal zmughal deleted the scenegraph-curie-impl branch September 23, 2020 17:41
@zmughal zmughal mentioned this pull request Sep 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component:gui enhancement
Projects
None yet
Milestone
curie v0.005
Development

Successfully merging this pull request may close these issues.
2 participants
@zmughal @coveralls