公式情報取得時にidStringをアップデートするように #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
これが変わることもある
There was a problem hiding this comment.
Pull Request Overview
This PR updates the OfficialMusic model and the OfficialMusicService to allow and log updates to the IdString property.
- Modified the OfficialMusic model to change IdString from an init-only property to a settable property.
- Updated the FetchAndSaveOfficialMusicAsync method to log and update IdString when discrepancies are detected.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OngekiMuseumApi/OngekiMuseumApi/Services/OfficialMusicService.cs | Added logic to detect changes and log updates for IdString. |
| OngekiMuseumApi/OngekiMuseumApi/Models/OfficialMusic.cs | Changed IdString property to allow modifications. |
Comments suppressed due to low confidence (1)
OngekiMuseumApi/OngekiMuseumApi/Services/OfficialMusicService.cs:216
- Consider adding tests to verify the new logic for updating and logging the IdString property to ensure it handles empty and null values as expected.
if (!string.Equals(existingMusic.IdString, NullIfEmpty(musicJson.id)))
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
これが変わることもある（かわらないで＞＜）
This pull request includes changes to the
OngekiMuseumApiproject to improve the handling and logging of theIdStringproperty in theOfficialMusicmodel and its associated service.Changes to
OfficialMusicmodel and service:OngekiMuseumApi/OngekiMuseumApi/Models/OfficialMusic.cs: Changed theIdStringproperty frominittosetto allow for updates.OngekiMuseumApi/OngekiMuseumApi/Services/OfficialMusicService.cs: Added logging and updating logic for theIdStringproperty in theFetchAndSaveOfficialMusicAsyncmethod.