カラム名が公式と違っている問題を修正 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes inconsistencies with official column names by converting property names to snake_case and adds a new uuid field in the response object.
- Changed property names from PascalCase to snake_case for consistency.
- Introduced a new uuid field in the response.
Comments suppressed due to low confidence (1)
OngekiMuseumApi/OngekiMuseumApi/Controllers/Api/OfficialMusicController.cs:108
- The 'uuid' field does not include a null-coalescing operator like the other fields. Consider handling potential null values for consistency.
uuid = music.Uuid,
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
CreateMusicResponseListmethod in theOfficialMusicControllerclass to improve consistency and add a new field. The most important changes include renaming properties to use snake_case and adding a newuuidfield.Changes to property names and fields:
OngekiMuseumApi/OngekiMuseumApi/Controllers/Api/OfficialMusicController.cs: Renamed properties to use snake_case for consistency (@new,date,title,title_sort,artist,id,chap_id,chapter,character,chara_id,category,category_id,lunatic,bonus,copyright1,lev_bas,lev_adv,lev_exc,lev_mas,lev_lnt,image_url). (Fe3749e4L84)OngekiMuseumApi/OngekiMuseumApi/Controllers/Api/OfficialMusicController.cs: Added a newuuidfield to the response object. (Fe3749e4R84)