DBの接続設定をconmnectionStringではなく別個で登録するように #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the database connection settings by replacing the usage of a unified connection string with separate configuration entries registered via MySqlConnector.
- Introduces a MySqlConnectionStringBuilder with separate configuration values.
- Updates the DbContext setup to use the built connection string.
Files not reviewed (1)
- OngekiMuseumApi/OngekiMuseumApi/appsettings.Development.json: Language not supported
| var mySqlConnectionStringBuilder = new MySqlConnectionStringBuilder | ||
| { | ||
| Server = builder.Configuration["Database:Server"], | ||
| Port = Convert.ToUInt32(builder.Configuration["Database:Port"]), |
There was a problem hiding this comment.
The conversion from the configuration value to an unsigned integer may throw an exception if the configuration value is not a valid number. Consider using a safe parsing method like TryParse or adding explicit validation to handle invalid inputs.
Suggested change
| Port = Convert.ToUInt32(builder.Configuration["Database:Port"]), | |
| Port = TryParseUInt32(builder.Configuration["Database:Port"]), |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.