Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo-deny version in Dockerfile #1903

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

rbehjati
Copy link
Contributor

@rbehjati rbehjati commented Mar 8, 2021

Use latest version of cargo-deny to avoid git fetch failure errors:

2021-03-08 18:51:23 [ERROR] failed to fetch advisory database: git operation failed: reference 'refs/heads/master' not found; class=Reference (4); code=NotFound (-3)

Ref: EmbarkStudios/cargo-deny#336

Also splits the run-tests step in github-ci to run-cargo-test and run-bazel-test to avoid the No space left on device problem.

@google-cla google-cla bot added the cla: yes label Mar 8, 2021
@rbehjati rbehjati requested a review from tiziano88 March 8, 2021 19:13
Copy link
Contributor Author

@rbehjati rbehjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiziano88: The CI build kept failing with "No space left on device", right before the bazel build step, so I've split the run-tests step into two separate steps. Could you take another look?

@rbehjati rbehjati requested a review from tiziano88 March 9, 2021 18:14
@tiziano88
Copy link
Collaborator

I will update the required steps once this is submitted, they are set in https://github.com/project-oak/oak/settings/branch_protection_rules/4812031

@rbehjati
Copy link
Contributor Author

rbehjati commented Mar 9, 2021

I will update the required steps once this is submitted, they are set in https://github.com/project-oak/oak/settings/branch_protection_rules/4812031

I am not sure how to proceed with this. Is it possible to mark run-tests as a non-required step now? I believe my build is currently waiting for a status from that, but that step is removed (because it consistently failed due to lack of space on disk).

@tiziano88
Copy link
Collaborator

Ah sorry, removed that now, I will add the others after this is submitted.

* Updates the carg-deny version
* Splits `run-tests` into `run-cargo-tests` and `run-bazel-tests` to
  make ci builds more stable
@rbehjati rbehjati merged commit 533fd29 into project-oak:main Mar 9, 2021
@rbehjati rbehjati deleted the cargo-deny branch March 9, 2021 21:02
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

Reproducibility Index:

d6bf09c6b84df6a51210aebfda47bac9e704593e61e3a62abcf483c8af4f3b3f  ./examples/abitest/bin/abitest_0_frontend.wasm
589e9a738e5d5ec9630ddb731f1cfba326a7be00a2cd1f3ee48849745028e8d0  ./examples/abitest/bin/abitest_1_backend.wasm
053b3b5b53317fee05170e02bbca03ca4d0bc97f9c8dc966aea4f892e071b5e4  ./examples/abitest/bin/abitest_linear_handles.wasm
87dd6f0375b1fcea0e5b8b13adda6cbe6ca9a9eef4ab8557b65f90ac593d9cb7  ./examples/aggregator/bin/aggregator.wasm
d2330f52bbd3a930d2bc5bb0282df04824993d2fea4a8cf0fc90173f5fcd7525  ./examples/chat/bin/chat.wasm
5007802f7892d5100c1953296eb1d3a0272a9c6972329bf2ea3fcd44b5e1687d  ./examples/hello_world/bin/hello_world.wasm
601272baacbf8a4fd025f7b9c5bb40c7b56ba945fe16c37c2388258715489bfa  ./examples/hello_world/bin/translator.wasm
fd37c27cbda6702469249ecfde45ffc15421c973fab06195f335e6c5971c9edd  ./examples/http_server/bin/http_server.wasm
effdf048815faa00b15d3b9775926d341716a5db68ebc009454660222680e184  ./examples/injection/bin/injection.wasm
3b954f4946e0294fa6925305cc7f14818d6b931efdf6e68cb0a2297e694e464d  ./examples/private_set_intersection/bin/private_set_intersection.wasm
873229d9cfcfafb3cfe183174915ed7c5cb6175b6ff14b190caaf00839e965b4  ./examples/private_set_intersection/bin/private_set_intersection_handler.wasm
016cb29eb2e128d17dbcd50509f2e6e67e87a7837a9934c79c90cbb766ccff13  ./examples/proxy_attestation/bin/proxy_attestation_example.wasm
601272baacbf8a4fd025f7b9c5bb40c7b56ba945fe16c37c2388258715489bfa  ./examples/translator/bin/translator.wasm
dbf52868f38b55eeb5d1e812ebbe7c672a43f54dc0870103e5dc07233839e262  ./examples/trusted_database/bin/trusted_database.wasm
7f3d64d1f6896989bcffd33b9189188579eb4f80105eb6d8bb5f2ac5ca770fbd  ./oak_loader/bin/oak_loader

Reproducibility Index diff:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants