feature/PM-460-complete-odrive-python-interface #3
Conversation
…e iMotioncube in the march OS.
| @property | ||
| def motor_error(self): | ||
| """Return the axis specific error.""" | ||
| return self._axis.motor.error | ||
|
|
||
| @property | ||
| def current_state(self): | ||
| """Return the current state of the motor.""" |
There was a problem hiding this comment.
What is included in the "current_state"? Is that an error state? Is that the motor position?
There was a problem hiding this comment.
current state is more or less an action state of the specified axis, this link should provide more information.
There was a problem hiding this comment.
I have added the states as well as all the possible modes as class dictionary variables. This way the operator can access these variables if necessary
There was a problem hiding this comment.
Hmm perhaps add a comment/docstring explaining what kind of "modes" this can be or something?
There was a problem hiding this comment.
added some small descriptive comments at the top to explain better what states and modes do.
…-research into feature/PM-460-complete-odrive-python-interface
…veMotor. Also updated the comments of a few function to better describe the functionalities
| @property | ||
| def motor_error(self): | ||
| """Return the axis specific error.""" | ||
| return self._axis.motor.error | ||
|
|
||
| @property | ||
| def current_state(self): | ||
| """Return the current state of the motor.""" |
There was a problem hiding this comment.
Hmm perhaps add a comment/docstring explaining what kind of "modes" this can be or something?
…odes, states and error.
.travis.yml
Outdated
| @@ -43,7 +43,7 @@ jobs: | |||
| env: ROS_DISTRO=melodic CLANG_FORMAT_CHECK=file | |||
| - name: "flake8" | |||
| language: python | |||
| python: 3.7 | |||
| python: 2.7 | |||
There was a problem hiding this comment.
Wasn't ODrive code in python 3? :O
There was a problem hiding this comment.
odrive supports both python 3 and 2
Closes PM-460
Description
In order to successfully integrate the Odrive in the OS of the exoskeleton the functionalities which are now available in the iMotionCube should also be integrated in the Odrive Interface. This PR adds all the necessary parameters and functionalities to complete the Odrive interface.
Changes